Skip to content

feat: Support custom types (enums/structs) in topic0 encoding for Ethereum events#2902

Open
Gmin2 wants to merge 1 commit intosubquery:mainfrom
Gmin2:topic0-encd
Open

feat: Support custom types (enums/structs) in topic0 encoding for Ethereum events#2902
Gmin2 wants to merge 1 commit intosubquery:mainfrom
Gmin2:topic0-encd

Conversation

@Gmin2
Copy link
Copy Markdown
Contributor

@Gmin2 Gmin2 commented Sep 3, 2025

Description

  • Add support for custom Solidity types (enums and structs) in Ethereum event topic0 encoding
  • Automatically resolve enum types to uint8 and struct types to tuple format before keccak256 hashing

Fixes #1772

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

stwiname
stwiname requested changes Sep 3, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@stwiname stwiname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Gmin2, this isn't what were after.

The feature isn't just for generating/importing abis. It's for at runtime when calculating the hash so that in the project manifest where are tuples/structs/enums.

For some more direction, these functions would need to be updated to be able to use ABIs to convert the signatures, like you have done. https://github.com/subquery/subql-ethereum/blob/main/packages/node/src/utils/string.ts#L22-L44

@Gmin2
Copy link
Copy Markdown
Contributor Author

Gmin2 commented Sep 4, 2025

Hey @stwiname i have made a commit in repo subql-ethereum take a look in it and tell me if thats what yu were looking for and have some doubts there

subquery/subql-ethereum@main...MeshPort-Labs:subql-ethereum:feat/runtime-abi

@stwiname
Copy link
Copy Markdown
Collaborator

stwiname commented Sep 8, 2025

@Gmin2, this is looking much better. I think for solving the dictionary issue, it would be best to resolve the filters when the project loads so that the updated filters are available everywhere.

If you create a PR with that work then i can provide more feedback

@Gmin2
Copy link
Copy Markdown
Contributor Author

Gmin2 commented Oct 17, 2025

Hey @stwiname just made the pr subquery#397 take a look at that

@Gmin2 Gmin2 requested a review from stwiname October 17, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stwiname stwiname Awaiting requested review from stwiname

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[$1200 in SQT] Support custom types in the topic0 encoding

2 participants

@Gmin2 @stwiname